chore: migrate to screens v4 and navigation v7 #6622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
alduzy
force-pushed
the
@alduzy/screens-and-navigation-bump
branch
from
3a02630 to
b37327f
Compare
maciekstosio
approved these changes
Oct 23, 2024
alduzy
added a commit
to software-mansion/react-native-screens
that referenced
this pull request
Oct 23, 2024
## Description This PR changes `ScreenStackHeaderConfig` into a [forwardRef](@alduzy/reanimated-patch). This is needed if you want to attach `ref` to it, which **react-native-reanimated** needs to do [here](https://github.com/software-mansion/react-native-reanimated/blob/1d417a5c711d60822d25bd8b823f1f5968214bde/apps/common-app/src/examples/ScreenStackHeaderConfigBackgroundColorExample.tsx#L24) in order to migrate to v4, since the header config is now a function component and cannot be used directly anymore. Without this change the app crashes with `Cannot read property 'getScrollableNode' of null`. Related PR: software-mansion/react-native-reanimated#6622 <!-- ## Changes Please describe things you've changed here, make a **high level** overview, if change is simple you can omit this section. For example: - Updated `about.md` docs --> <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> <!-- ## Test code and steps to reproduce Please include code that can be used to test this change and short description how this example should work. This snippet should be as minimal as possible and ready to be pasted into editor (don't exclude exports or remove "not important" parts of reproduction example) --> ## Checklist - [x] Ensured that CI passes
tomekzaw
reviewed
Nov 11, 2024
tomekzaw
approved these changes
Nov 13, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Summary When working on #6622 I noticed the web example app is not bundling. I found out it stopped working when the rest of the examples were updated to RN 0.76. This PR bumps the version of `react-native` and `expo` fixing the problem and making it compatible with the rest of the repository. ## Test plan Build and run the web example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps version of the
react-native-screenspackage to v4 and@react-navigationpackages to v7.Changes
react-native-screens