Merge pull request #8 from softonic/Fix-headers-error

Fix headers error
softonic · Mar 16, 2022 · 1dca2b3 · 1dca2b3
2 parents 169e9ef + 3da075d
commit 1dca2b3
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 1 deletion.
diff --git a/src/ExternalEvents.php b/src/ExternalEvents.php
@@ -41,7 +41,7 @@ public static function decorateListener(string $listenerClass): \Closure
             try {
                 $listener = resolve($listenerClass);
 
-                if (method_exists($listener, 'setHeaders')) {
+                if (!empty($message[0]['headers']) && method_exists($listener, 'setHeaders')) {
                     $listener->setHeaders($message[0]['headers']);
                 }
 

diff --git a/tests/ExternalEventsTest.php b/tests/ExternalEventsTest.php
@@ -5,6 +5,7 @@
 use BadMethodCallException;
 use Orchestra\Testbench\TestCase;
 use function PHPUnit\Framework\assertSame;
+use function PHPUnit\Framework\assertTrue;
 use Softonic\LaravelProtobufEvents\Exceptions\InvalidMessageException;
 use Softonic\LaravelProtobufEvents\FakeProto\FakeMessage;
 
@@ -117,6 +118,36 @@ public function handle(FakeMessage $message)
         ExternalEvents::decorateListener($listener::class)(':event:', [['data' => $message->serializeToJsonString()]]);
     }
 
+    /**
+     * @test
+     */
+    public function whenDecoratingAListenerWithSetHeadersMethodButWithoutSendingHeadersItShouldExecuteIt(): void
+    {
+        $listener = new class() {
+            public function setHeaders(array $headers)
+            {
+                assertTrue(false, 'setHeaders() should not be executed if no headers are received');
+            }
+
+            public function handle(FakeMessage $message)
+            {
+                assertSame(':content:', $message->getContent());
+            }
+        };
+
+        $message = new FakeMessage();
+        $message->setContent(':content:');
+
+        ExternalEvents::decorateListener($listener::class)(
+            ':event:',
+            [
+                [
+                    'data' => $message->serializeToJsonString(),
+                ],
+            ]
+        );
+    }
+
     /**
      * @test
      */