Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__hotfix: GNB의 active된 link의 스타일링에 breakPoint 수정 #135

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

thgee
Copy link
Member

@thgee thgee commented Aug 28, 2024

📗 작업 내용

이슈 내용

image
  • GNB에서 현재 페이지 표시의 breakpoint GNB_BREAKPOINT 가 아닌, MOBILE_BREAKPOINT 로 설정되어있던 이슈

변경 사항

  • breakpointGNB_BREAKPOINT로 변경

✏️ 리뷰어 멘션

@thgee thgee requested a review from DaeWon9 August 28, 2024 08:05
@thgee thgee self-assigned this Aug 28, 2024
@thgee thgee deployed to admin-preview August 28, 2024 08:05 — with GitHub Actions Active
@thgee thgee deployed to service-preview August 28, 2024 08:05 — with GitHub Actions Active
Copy link
Collaborator

@DaeWon9 DaeWon9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중간단계의 뷰에서 저런 오류가 있었군요.
꼼꼼하게 확인하는 모습 좋습니다.!

Copy link

Visit the preview URL for this PR (updated for commit 4eaec5a):

https://watermelon-clap--pr135-hotfix-r8vyzkat.web.app

(expires Wed, 04 Sep 2024 08:06:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: de0a942c5b755c54117c0c98d9eeaa5a5c97c307

Copy link

Finish "service" deployment!

@thgee thgee merged commit 37b5819 into main Aug 28, 2024
3 checks passed
@thgee thgee deleted the __hotfix branch August 28, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants