Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: 아이폰에서 배너이미지가 화면에 꽉 차는 이슈 #134

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

thgee
Copy link
Member

@thgee thgee commented Aug 26, 2024

📗 작업 내용

이슈 내용

  • 아이폰에서 배너이미지가 화면에 가득 차는 이슈가 발생

변경 사항

  • height : fit-content -> height : auto 로 수정

✏️ 리뷰어 멘션

@thgee thgee requested a review from DaeWon9 August 26, 2024 08:23
@thgee thgee self-assigned this Aug 26, 2024
@thgee thgee temporarily deployed to admin-preview August 26, 2024 08:23 — with GitHub Actions Inactive
@thgee thgee temporarily deployed to service-preview August 26, 2024 08:23 — with GitHub Actions Inactive
Copy link
Collaborator

@DaeWon9 DaeWon9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아이폰에서 fit-content가 적용되지 않는 이슈가 있었군요..
고생하셨습니다.

Copy link

Visit the preview URL for this PR (updated for commit 07c916e):

https://watermelon-clap--pr134-hotfix-u4fl35zv.web.app

(expires Mon, 02 Sep 2024 08:24:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: de0a942c5b755c54117c0c98d9eeaa5a5c97c307

Copy link

Finish "service" deployment!

@thgee thgee merged commit aa63839 into main Aug 26, 2024
3 checks passed
@thgee thgee deleted the __hotfix branch August 26, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants