Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CLAP-183): 선착순 이벤트 기간 노출 이슈 #131

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

DaeWon9
Copy link
Collaborator

@DaeWon9 DaeWon9 commented Aug 26, 2024

🔗 연관된 이슈


📗 작업 내용

서버에서 받아온 선착순이벤트 정보를 바탕으로
선착순이벤트의 전체 기간을 노출하도록 함.

이슈 내용

  • 노출되는 선착순 이슈의 전체 기간이 실제 기간과 맞지 않는 이슈

변경 사항

  • 서버에서 받아온 데이터를 바탕으로 날짜를 파싱하여 노출되도록 수정

✏️ 리뷰어 멘션

@DaeWon9 DaeWon9 requested a review from thgee August 26, 2024 02:44
@DaeWon9 DaeWon9 self-assigned this Aug 26, 2024
@DaeWon9 DaeWon9 temporarily deployed to service-preview August 26, 2024 02:45 — with GitHub Actions Inactive
Copy link

Visit the preview URL for this PR (updated for commit 81ef26e):

https://watermelon-clap--pr131-fix-clap-183-jnc8l4if.web.app

(expires Mon, 02 Sep 2024 02:45:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: de0a942c5b755c54117c0c98d9eeaa5a5c97c307

Copy link

Finish "service" deployment!

Copy link
Member

@thgee thgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

선착순 이벤트의 기간을 서버에서 받아올 수 있도록 수정하였군요..
마지막까지 우리 서비스의 완성도를 높이는 모습이 감동적입니다 🥲

@DaeWon9 DaeWon9 merged commit a3cbbc0 into main Aug 26, 2024
3 checks passed
@DaeWon9 DaeWon9 deleted the fix/CLAP-183 branch August 26, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants