Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: GNB 스타일링, 이미지 크기조절, 각종 UX 개선 #129

Merged
merged 10 commits into from
Aug 25, 2024

Conversation

thgee
Copy link
Member

@thgee thgee commented Aug 25, 2024

📗 작업 내용

변경 사항

  • GNB에 현재 페이지에 따라 밑줄표시
  • 로그인 타이머 width 고정
  • 로그인 연장시 뜨던 모달 삭제
  • 메인배너 화면에 꽉 차도록 수정
  • 배너이미지 아래에 스크롤 유도 아이콘 렌더링

✏️ 리뷰어 멘션

@thgee thgee requested a review from DaeWon9 August 25, 2024 04:01
@thgee thgee self-assigned this Aug 25, 2024
@thgee thgee temporarily deployed to service-preview August 25, 2024 04:01 — with GitHub Actions Inactive
@thgee thgee temporarily deployed to admin-preview August 25, 2024 04:01 — with GitHub Actions Inactive
Copy link

github-actions bot commented Aug 25, 2024

Visit the preview URL for this PR (updated for commit ed288e6):

https://watermelon-clap--pr129-hotfix-86k586du.web.app

(expires Sun, 01 Sep 2024 04:29:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: de0a942c5b755c54117c0c98d9eeaa5a5c97c307

Copy link

Finish "service" deployment!

@thgee thgee temporarily deployed to admin-preview August 25, 2024 04:28 — with GitHub Actions Inactive
@thgee thgee temporarily deployed to service-preview August 25, 2024 04:28 — with GitHub Actions Inactive
Copy link
Collaborator

@DaeWon9 DaeWon9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사소한 부분까지 신경써주셔서, 사용자 UX가 더 좋아졌군요!
고생하셨습니다.

@thgee thgee merged commit 284d74e into main Aug 25, 2024
3 checks passed
@thgee thgee deleted the __hotfix branch August 25, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants