Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLAP-173): HTML Metadata 설정 #115

Merged
merged 3 commits into from
Aug 22, 2024
Merged

feat(CLAP-173): HTML Metadata 설정 #115

merged 3 commits into from
Aug 22, 2024

Conversation

thgee
Copy link
Member

@thgee thgee commented Aug 22, 2024

🔗 연관된 이슈


📗 작업 내용

변경 사항

  • favicon, 페이지별 title, og태그 설정
image

✏️ 리뷰어 멘션

@thgee thgee added the ✨ feat label Aug 22, 2024
@thgee thgee requested a review from DaeWon9 August 22, 2024 08:47
@thgee thgee self-assigned this Aug 22, 2024
@thgee thgee temporarily deployed to service-preview August 22, 2024 08:47 — with GitHub Actions Inactive
@thgee thgee temporarily deployed to admin-preview August 22, 2024 08:47 — with GitHub Actions Inactive
@thgee thgee changed the title feat(CLAP-173): HTML Medadata 설정 feat(CLAP-173): HTML Metadata 설정 Aug 22, 2024
Copy link
Collaborator

@DaeWon9 DaeWon9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

타이틀 및 og태그 적용을 시도하셨군요!
보기좋습니다.

Copy link

Visit the preview URL for this PR (updated for commit 49c6e8c):

https://watermelon-clap-admin--pr115-feat-clap-173-nqige1ml.web.app

(expires Thu, 29 Aug 2024 08:48:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 943733d5a28ca30754e62bc993020185916875a2

Copy link

Finish "admin" deployment!

Copy link

Visit the preview URL for this PR (updated for commit 49c6e8c):

https://watermelon-clap--pr115-feat-clap-173-ank8dqk3.web.app

(expires Thu, 29 Aug 2024 08:48:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: de0a942c5b755c54117c0c98d9eeaa5a5c97c307

Copy link

Finish "service" deployment!

@thgee thgee merged commit 25d740e into main Aug 22, 2024
3 checks passed
@thgee thgee deleted the feat/CLAP-173 branch August 22, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants