release rpc version 5.14.0-SNAPSHOT #1458
Conversation
WalkthroughThe changes in this pull request primarily involve updating version numbers in various Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
pom.xml (1)
Line range hint
449-452: Fix typo in Javadoc property nameThe property
maven.javadoc.quitecontains a typo and should bemaven.javadoc.quiet. This incorrect property name prevents Maven from properly controlling Javadoc output during releases.Apply this fix:
<properties> - <maven.javadoc.quite>true</maven.javadoc.quite> + <maven.javadoc.quiet>true</maven.javadoc.quiet> <maven.javadoc.skip>false</maven.javadoc.skip> </properties>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (4)
all/pom.xml(1 hunks)bom/pom.xml(1 hunks)core/api/src/main/java/com/alipay/sofa/rpc/common/Version.java(1 hunks)pom.xml(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- all/pom.xml
- core/api/src/main/java/com/alipay/sofa/rpc/common/Version.java
🔇 Additional comments (1)
bom/pom.xml (1)
13-13: LGTM! Version update follows semantic versioning.
The version change from 5.13.2 to 5.14.0-SNAPSHOT is appropriate for a new development cycle, indicating new features will be added without breaking changes.
Let's verify version consistency across all pom files:
✅ Verification successful
Version consistency verified across the project
The verification shows that:
- The
revisionproperty is correctly set to5.14.0-SNAPSHOTin the BOM - All modules properly inherit the version through
${revision}or${project.version} - No references to the old version
5.13.2were found - The version inheritance chain is intact through parent-child relationships
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check version consistency across pom files
# Expected: All pom files should reference the same version (5.14.0-SNAPSHOT)
echo "Checking version consistency across pom files..."
# Find all pom.xml files and check for version references
fd --type f "pom.xml$" --exec grep -l "5\.14\.0-SNAPSHOT\|revision" {} \;
# Verify no old version references remain
echo "Checking for old version references..."
rg "5\.13\.2" --type xml
Length of output: 2149
Script:
#!/bin/bash
# Let's check the actual version references in pom files
# First, check for direct version references
echo "Checking direct version references..."
fd "pom.xml$" --exec grep -A 1 "<version>" {} \;
# Then check revision property references
echo -e "\nChecking revision property references..."
fd "pom.xml$" --exec grep -A 1 "<revision>" {} \;
# Finally check parent version references
echo -e "\nChecking parent version references..."
fd "pom.xml$" --exec grep -A 3 "<parent>" {} \;
Length of output: 43170
| @@ -77,7 +77,7 @@ | |||
|
|
|||
| <properties> | |||
| <!-- Build args --> | |||
| <revision>5.13.2</revision> | |||
| <revision>5.14.0-SNAPSHOT</revision> | |||
There was a problem hiding this comment.
💡 Codebase verification
Version update needs attention
The version update to 5.14.0-SNAPSHOT is inconsistent across the codebase:
- POM files correctly use
5.14.0-SNAPSHOTversion - However,
Version.javauses non-snapshot versions:VERSION = "5.14.0"BUILD_VERSION = "5.14.0_20241101180137"
This inconsistency between POM files and Version.java should be addressed. The Version.java constants should reflect that this is a SNAPSHOT release.
🔗 Analysis chain
Version update looks good!
The version bump from 5.13.2 to 5.14.0-SNAPSHOT follows semantic versioning and aligns with the release objectives.
Let's verify version consistency across all POM files:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check version consistency across all POM files
# Expected: All POMs should reference 5.14.0-SNAPSHOT
echo "Checking version references in POM files..."
find . -name "pom.xml" -type f -exec grep -H "<revision>" {} \;
Length of output: 277
Script:
#!/bin/bash
# Let's also check for any direct version references in POM files
# that might not be using the revision property
echo "Checking for direct version references..."
find . -name "pom.xml" -type f -exec grep -H "<version>5" {} \;
# Also check Version.java file for consistency
echo -e "\nChecking Version.java file..."
find . -name "Version.java" -type f -exec grep -H "VERSION" {} \;
Length of output: 793
release rpc version 5.14.0-SNAPSHOT
Summary by CodeRabbit
New Features
5.14.0-SNAPSHOT, indicating ongoing development with potential new features.Bug Fixes
These updates enhance the project's versioning and build processes, preparing it for future developments.