Support bzip2 and gzip compress #1399

wangchengming666 · 2024-02-28T06:24:44Z

Summary by CodeRabbit

New Features
- Enhanced data compression efficiency in RPC communication by introducing Bzip2 and Gzip compression options.
Tests
- Ensured the reliability of Bzip2 and Gzip compression functionalities through added tests.

codecov · 2024-02-28T06:40:47Z

Codecov Report

Attention: Patch coverage is 64.44444% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 72.04%. Comparing base (df2dcae) to head (cf0ae0d).
Report is 7 commits behind head on master.

❗ Current head cf0ae0d differs from pull request most recent head 2e89cbc. Consider uploading reports for the commit 2e89cbc to get more accurate results

Files	Patch %	Lines
...alipay/sofa/rpc/codec/biz2/Bzip2RpcCompressor.java	65.21%	6 Missing and 2 partials ⚠️
.../alipay/sofa/rpc/codec/gzip/GzipRpcCompressor.java	63.63%	4 Missing and 4 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1399      +/-   ##
============================================
+ Coverage     72.02%   72.04%   +0.01%     
- Complexity      791      793       +2     
============================================
  Files           422      424       +2     
  Lines         17813    17859      +46     
  Branches       2769     2772       +3     
============================================
+ Hits          12830    12866      +36     
- Misses         3568     3574       +6     
- Partials       1415     1419       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coderabbitai · 2024-03-26T01:29:33Z

Warning

Rate Limit Exceeded

@EvenLjj has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 20 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 0a054bf and 2e89cbc.

Walkthrough

The update introduces a new dependency on commons-compress version 1.25.0 in the pom.xml file and extends support for bzip2 and gzip compressors alongside snappy in the codec-api service for sofa-rpc. These changes enrich compression options and library dependencies within the project.

Changes

Files	Summary
`bom/pom.xml`	Added `commons-compress` dependency with version `1.25.0` and related property declarations.
`codec/codec-api/src/main/resources/META-INF/services/sofa-rpc/com.alipay.sofa.rpc.codec.Compressor`	Added support for `bzip2` and `gzip` compressors alongside `snappy` in the codec service.

Possibly related issues

【Proposal】支持更丰富的压缩算法方便用户在不同的场景选择 #1398: The addition of bzip2 and gzip compressors in this PR aligns with the proposal to support more compression algorithms in SOFA-RPC, fulfilling the objective of providing users with a broader selection of compression options.

Poem

Code and data in a dance so tight,
New dependencies shine, oh so bright.
Compressors added, choices now vast,
Enhancing SOFA-RPC, a change so vast.
🐰 "In the world of bytes, a symphony in play,
With gzip and bzip2, efficiency finds its way."
🌟 Libraries and algorithms in harmony blend,
SOFA-RPC's capabilities ascend.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Review Status

Actionable comments generated: 4

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 70f16f3 and 8deb606.

Files ignored due to path filters (2)

bom/pom.xml is excluded by: !**/*.xml
codec/codec-api/pom.xml is excluded by: !**/*.xml

Files selected for processing (5)

codec/codec-api/src/main/java/com/alipay/sofa/rpc/codec/biz2/Bzip2RpcCompressor.java (1 hunks)
codec/codec-api/src/main/java/com/alipay/sofa/rpc/codec/gzip/GzipRpcCompressor.java (1 hunks)
codec/codec-api/src/main/resources/META-INF/services/sofa-rpc/com.alipay.sofa.rpc.codec.Compressor (1 hunks)
codec/codec-api/src/test/java/com/alipay/sofa/rpc/codec/biz2/Bzip2RpcCompressorTest.java (1 hunks)
codec/codec-api/src/test/java/com/alipay/sofa/rpc/codec/gzip/GzipRpcCompressorTest.java (1 hunks)

Additional comments: 1

codec/codec-api/src/main/java/com/alipay/sofa/rpc/codec/biz2/Bzip2RpcCompressor.java (1)

34-75: The implementation of both compression and decompression methods in Bzip2RpcCompressor is correct and follows best practices. The use of BZip2CompressorOutputStream and BZip2CompressorInputStream from the Apache Commons Compress library is appropriate for the bzip2 algorithm. Error handling is consistent and appropriate.

...codec-api/src/main/resources/META-INF/services/sofa-rpc/com.alipay.sofa.rpc.codec.Compressor

codec/codec-api/src/test/java/com/alipay/sofa/rpc/codec/biz2/Bzip2RpcCompressorTest.java

codec/codec-api/src/test/java/com/alipay/sofa/rpc/codec/gzip/GzipRpcCompressorTest.java

codec/codec-api/src/main/java/com/alipay/sofa/rpc/codec/gzip/GzipRpcCompressor.java

# Conflicts: # bom/pom.xml

…ompress

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 8deb606 and b8d2e43.

Files ignored due to path filters (1)

bom/pom.xml is excluded by !**/*.xml

Files selected for processing (1)

codec/codec-api/src/main/java/com/alipay/sofa/rpc/codec/gzip/GzipRpcCompressor.java (1 hunks)

Files skipped from review as they are similar to previous changes (1)

codec/codec-api/src/main/java/com/alipay/sofa/rpc/codec/gzip/GzipRpcCompressor.java

…com.alipay.sofa.rpc.codec.Compressor Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b8d2e43 and 6978230.

Files selected for processing (2)

bom/pom.xml (4 hunks)
codec/codec-api/src/main/resources/META-INF/services/sofa-rpc/com.alipay.sofa.rpc.codec.Compressor (1 hunks)

Files skipped from review due to trivial changes (2)

bom/pom.xml
codec/codec-api/src/main/resources/META-INF/services/sofa-rpc/com.alipay.sofa.rpc.codec.Compressor

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6978230 and 0a054bf.

Files selected for processing (1)

codec/codec-api/src/test/java/com/alipay/sofa/rpc/codec/biz2/Bzip2RpcCompressorTest.java (1 hunks)

Files skipped from review due to trivial changes (1)

codec/codec-api/src/test/java/com/alipay/sofa/rpc/codec/biz2/Bzip2RpcCompressorTest.java

…zip2RpcCompressorTest.java Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

EvenLjj

LGTM

support for sofastack#1398

09b6f23

sofastack-cla bot added cla:yes CLA is ok size/L labels Feb 28, 2024

wangchengming666 mentioned this pull request Feb 28, 2024

【Proposal】支持更丰富的压缩算法方便用户在不同的场景选择 #1398

Closed

Merge branch 'master' into support-compress

8deb606

coderabbitai bot reviewed Mar 26, 2024

View reviewed changes

呈铭 added 3 commits March 28, 2024 13:15

Merge branch 'master' into support-compress

dfca19f

# Conflicts: # bom/pom.xml

support compress

26518ca

Merge remote-tracking branch 'origin/support-compress' into support-c…

b8d2e43

…ompress

coderabbitai bot reviewed Mar 28, 2024

View reviewed changes

呈铭 and others added 3 commits March 28, 2024 13:21

support compress

fc1b52d

support compress

cf0ae0d

Update codec/codec-api/src/main/resources/META-INF/services/sofa-rpc/…

6978230

…com.alipay.sofa.rpc.codec.Compressor Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

coderabbitai bot reviewed May 9, 2024

View reviewed changes

Update codec/codec-api/src/test/java/com/alipay/sofa/rpc/codec/biz2/B…

2e89cbc

…zip2RpcCompressorTest.java Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

EvenLjj force-pushed the support-compress branch from 0a054bf to 2e89cbc Compare May 9, 2024 12:53

EvenLjj approved these changes May 9, 2024

View reviewed changes

Lo1nt approved these changes May 10, 2024

View reviewed changes

EvenLjj merged commit 279ea0d into sofastack:master May 10, 2024
4 checks passed

EvenLjj added this to the 5.13.0 milestone May 10, 2024

wangchengming666 deleted the support-compress branch May 14, 2024 05:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support bzip2 and gzip compress #1399

Support bzip2 and gzip compress #1399

wangchengming666 commented Feb 28, 2024 •

edited by coderabbitai bot

Loading

codecov bot commented Feb 28, 2024 •

edited

Loading

coderabbitai bot commented Mar 26, 2024 •

edited

Loading

Rate Limit Exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

EvenLjj left a comment

Support bzip2 and gzip compress #1399

Support bzip2 and gzip compress #1399

Conversation

wangchengming666 commented Feb 28, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

codecov bot commented Feb 28, 2024 • edited Loading

Codecov Report

coderabbitai bot commented Mar 26, 2024 • edited Loading

Rate Limit Exceeded

Walkthrough

Changes

Possibly related issues

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

EvenLjj left a comment

Choose a reason for hiding this comment

wangchengming666 commented Feb 28, 2024 •

edited by coderabbitai bot

Loading

codecov bot commented Feb 28, 2024 •

edited

Loading

coderabbitai bot commented Mar 26, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)