Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add release workflow #331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nobodyiam
Copy link
Member

@nobodyiam nobodyiam commented Jul 5, 2023

Motivation:

Add a release workflow so that it's easy to deploy artifacts to maven central repository.

Modification:

  1. upgrade maven-javadoc-plugin to use the configuration doclint
  2. add --pinentry-mode option to maven-gpg-plugin
  3. add a release workflow so that we could use github action to release the artifacts
    • The workflow uses java 8 to deploy the registry clients as the maven command provided in action/setup-java doesn't support java 6 anymore.
    • We need to determine whether it's ok to drop java 6 support.

Result:

Fixes #327

Sample workflow: https://github.com/nobodyiam/sofa-registry/actions/workflows/release.yml
image

And the uploaded artifacts could be found in the staging repo:
image

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #331 (9cb0cff) into master (808b7dc) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #331      +/-   ##
============================================
- Coverage     76.54%   76.52%   -0.02%     
  Complexity       48       48              
============================================
  Files           495      495              
  Lines         18488    18488              
  Branches       1802     1802              
============================================
- Hits          14151    14148       -3     
- Misses         3525     3526       +1     
- Partials        812      814       +2     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808b7dc...9cb0cff. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

registry-test is not uploaded to maven central repository since 6.0.0
1 participant