Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove un-used parameter _sort_key from api.py #892

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove un-used parameter _sort_key from api.py #892

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e9d57e6
fixes issue #886
UtkarshShah0 Apr 26, 2022
60519e8
Merge branch 'master' into remove_sortk_unused
joseph-v Apr 29, 2022
afca73b
Merge branch 'master' into remove_sortk_unused
anvithks Apr 30, 2022
e488242
Merge branch 'master' into remove_sortk_unused
sushanthakumar May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion delfin/db/sqlalchemy/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2969,7 +2969,7 @@ def process_sort_params(sort_keys, sort_dirs, default_keys=None,
raise exception.InvalidInput(msg)
result_dirs.append(sort_dir)
else:
result_dirs = [default_dir_value for _sort_key in result_keys]
result_dirs = [default_dir_value for _ in result_keys]

# Ensure that the key and direction length match
while len(result_dirs) < len(result_keys):
Expand Down