Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove un-used parameter _sort_key from api.py #892

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove un-used parameter _sort_key from api.py #892

wants to merge 4 commits into from

Conversation

UtkarshShah0
Copy link
Contributor

What this PR does / why we need it:
Removed un-used parameter _sort_key from delfin/db/sqlalchemy/api.py and replaced it with

Which issue this PR fixes:
fixes #886

Special notes for your reviewer:
SODACODE 2022

@UtkarshShah0
fixes issue sodafoundation#886
e9d57e6 
Removed un-used param _sort_key from delfin/db/sqlalchemy/api.py
@codecov
Copy link

codecov bot commented Apr 26, 2022 •
edited
Loading

Codecov Report

Merging #892 (afca73b) into master (0272eed) will not change coverage.
The diff coverage is 100.00%.

❗ Current head afca73b differs from pull request most recent head e488242. Consider uploading reports for the commit e488242 to get more accurate results

@@           Coverage Diff           @@
##           master     #892   +/-   ##
=======================================
  Coverage   70.47%   70.47%           
=======================================
  Files         181      181           
  Lines       19055    19055           
  Branches     2812     2812           
=======================================
  Hits        13429    13429           
  Misses       4756     4756           
  Partials      870      870
Impacted Files Coverage Δ
delfin/db/sqlalchemy/api.py 71.91% <100.00%> (ø)

joseph-v
joseph-v approved these changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseph-v joseph-v added SODACODE2022 SODACODE2022 Hackathon Label SODALOW SODACODE2022 Hackathon Priority Label labels Apr 28, 2022
@joseph-v joseph-v changed the title fixes issue #886 Remove un-used parameter _sort_key from api.py Apr 29, 2022
@UtkarshShah0
Copy link
Contributor Author

@skdwriting Please review and approve. One more approval required

@anvithks
Copy link
Member

LGTM

#SODA-PR-ACCEPTED
Based on @joseph-v approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushanthakumar sushanthakumar sushanthakumar approved these changes

@joseph-v joseph-v joseph-v approved these changes

Assignees
No one assigned
Labels
SODACODE2022 SODACODE2022 Hackathon Label SODALOW SODACODE2022 Hackathon Priority Label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove un-used param _sort_key from delfin/db/sqlalchemy/api.py
4 participants
@UtkarshShah0 @anvithks @joseph-v @sushanthakumar