[REVIEW] - Adds test for switch config types #784
Conversation
Result of running script to remove backslashes
```bash
find . -type f -exec sed -i ':a;N;$!ba;s/\\\n\s*//g' {} \;
```
There was a problem hiding this comment.
thanks for push this up @cjmakes ! Ill review it more in depth when I have some time later this week, but lets approve it so we can see how CI runs
also tagging @owendelong since this changes the formatting of the switchtypes files slightly
sarcasticadmin
changed the title
There was a problem hiding this comment.
@cjmakes this looks really good! Left my comments inline so let me know what you think
| meta = { | ||
| "file": directory + filename, | ||
| "header": False, | ||
| "count": "1+", |
There was a problem hiding this comment.
I think the count here should be 4+ since it looks like we have a mix of 4-6 columns for the config types
| "header": False, | ||
| "count": "1+", | ||
| "cols": [ | ||
| ds.isvalidport, |
There was a problem hiding this comment.
having isvalidport and isvalidlink is definitely a great start to testing these switch config types, nice work!
| exSigns,exVmVendor,vendor_backbone - Uplink | ||
| TRUNK ge-0/0/1 exSCALE-SLOW,exSCALE-FAST,exSpeaker,exInfra,exAVLAN, \ | ||
| exSigns,exVmVendor,vendor_backbone - Downlink | ||
| TRUNK ge-0/0/0 exSCALE-SLOW,exSCALE-FAST,exSpeaker,exInfra,exAVLAN, exSigns,exVmVendor,vendor_backbone - Uplink |
There was a problem hiding this comment.
Id prefer it we update test_datafile to support the \ for multiline entries. Would you mind seeing how feasible that approach would be?
|
Thanks for fixing the linting errors that came up in CI as well 👍 |
Description of PR
Previous Behavior
There was no automation to enforce consistency across switch config types.
Tests
This pr adds tests. I would appreciate feed back on how to make sure I didn't break any automation that parses the switch configs and relies on using \ to split a config across lines.
closes #676