fix: use xdg dir as default cli Path #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShawkyZ
commented
Dec 9, 2024
|
|
||
| const path = await this.configuration.getCliPath(); | ||
| // migration for moving from default extension path to xdg dirs. | ||
| if (CliExecutable.isPathInExtensionDirectory(this.extensionContext.extensionPath, path)) { |
There was a problem hiding this comment.
this might be unnecessary. But I want to ensure extension doesn't break for current preview users.
ShawkyZ
commented
Dec 9, 2024
| await this.configuration.getCliPath(), | ||
| ); | ||
| const cliPath = await this.configuration.getCliPath(); | ||
| const cliDir = path.dirname(cliPath); |
There was a problem hiding this comment.
this was the old logic that ensure cliDir exists.
bastiandoetsch
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!