Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dissable button after applying fix [IDE-779] #562

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

DariusZdroba
Copy link
Contributor

@DariusZdroba DariusZdroba commented Dec 6, 2024

Description

Setting the applyFix button to disabled after applying a certain fix.

By tracking the lastAppliedFix we can track, style and disable only the button corresponding to the AI Fix suggestion.
Since most of the styles were pushed to Language Server, the according style for the button can be found there.

This logic disables the button only for the last applied suggestion
( eg. if we have 3 suggestions and we apply suggestion1 , apply fix button for suggestion1 will be disabled, if we then apply fix of suggestion2, the button of suggestion1 will again be available ( enabled ), this prevents blocking the user from experimenting with multiple suggestions. )

Screenshot 2024-12-06 at 14 20 25

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@DariusZdroba DariusZdroba requested a review from a team as a code owner December 6, 2024 12:30
@DariusZdroba DariusZdroba changed the title fix: dissable button after applying fix fix: dissable button after applying fix [IDE-779] Dec 6, 2024
@bastiandoetsch bastiandoetsch merged commit 6bff18c into main Dec 6, 2024
10 checks passed
@bastiandoetsch bastiandoetsch deleted the fix/disable-apply-fix-button-affter-apply branch December 6, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants