Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autofix: fixed handling of empty suggestions #536

Merged
merged 2 commits into from
Oct 14, 2024
Merged

fix: autofix: fixed handling of empty suggestions #536

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6790bef
fix/autofix: fixed handling of empty suggestions
BBerabi Sep 27, 2024
e8deaa6
Merge branch 'main' into fix/autofix/empty-suggestions-handling
ShawkyZ Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/snyk/snykCode/views/suggestion/codeSuggestionWebviewProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,9 +265,8 @@ export class CodeSuggestionWebviewProvider
relativePath,
issueId,
);
if (diffs.length === 0) {
throw Error('Unable to generate a relevant fix');
}
// todo(berkay.berabi): Here if suggestions are empty, we should post a different type of message that
// will show the user correct information, namely: we tried but no fixes available for now.

void this.postSuggestMessage({ type: 'setAutofixDiffs', args: { suggestion, diffs } });
} catch (error) {
Expand Down
Loading