feat: move delta preview to settings [IDE-597]

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Snyk Security Changelog
 
+## [2.19.0]
+- Moved delta scan preview setting to settings page.
+
 ## [2.18.0]
 - Added base branch selection for IaC and OSS
 

package.json

@@ -255,6 +255,20 @@
             "description": "Preview features that are currently in development. Setting keys will be removed when features become stable.",
             "propertyNames": true,
             "properties": {}
+          },
+          "snyk.netNewVsAllIssues": {
+            "type": "string",
+            "default": "All issues",
+            "description": "Specifies whether to see only net new issues or all issues. Only applies to Code Security and Code Quality.",
+            "enum": [
+              "All issues",
+              "Net new issues"
+            ],
+            "enumDescriptions": [
+              "Shows all issues that have been identified, including both new and existing issues.",
+              "Shows only new issues that have been introduced in the latest scan, filtering out previously known issues."
+            ],
+            "markdownDescription": "Specifies whether to see only net new issues or all issues. Only applies to Code Security and Code Quality.\n\nNote: this is an experimental feature. Please reach out to [support.snyk.io](https://support.snyk.io) for more details."
           }
         }
       },

src/snyk/common/configuration/configuration.ts

@@ -31,6 +31,8 @@ import {
 import SecretStorageAdapter from '../vscode/secretStorage';
 import { IVSCodeWorkspace } from '../vscode/workspace';
 
+const NEWISSUES = 'Net new issues';
+
 export type FeaturesConfiguration = {
   ossEnabled: boolean | undefined;
   codeSecurityEnabled: boolean | undefined;
@@ -247,9 +249,11 @@ export class Configuration implements IConfiguration {
   }
 
   getDeltaFindingsEnabled(): boolean {
-    return (
-      this.workspace.getConfiguration<boolean>(CONFIGURATION_IDENTIFIER, this.getConfigName(DELTA_FINDINGS)) ?? false
+    const selectionValue = this.workspace.getConfiguration<string>(
+      CONFIGURATION_IDENTIFIER,
+      this.getConfigName(DELTA_FINDINGS),
     );
+    return selectionValue === NEWISSUES;
   }
 
   getAuthenticationMethod(): string {

src/snyk/common/constants/settings.ts

@@ -28,4 +28,4 @@ export const TRUSTED_FOLDERS = `${CONFIGURATION_IDENTIFIER}.trustedFolders`;
 export const FOLDER_CONFIGS = `${CONFIGURATION_IDENTIFIER}.folderConfigs`;
 export const SCANNING_MODE = `${CONFIGURATION_IDENTIFIER}.scanningMode`;
 
-export const DELTA_FINDINGS = `${FEATURES_PREVIEW_SETTING}.deltaFindings`;
+export const DELTA_FINDINGS = `${CONFIGURATION_IDENTIFIER}.netNewVsAllIssues`;

src/snyk/snykOss/providers/ossVulnerabilityTreeProvider.ts

@@ -120,10 +120,6 @@ export default class OssIssueTreeProvider extends ProductIssueTreeProvider<OssIs
 
       const folderSeverity = ProductIssueTreeProvider.getHighestSeverity(folderSeverityCounts);
 
-      if (folderVulnCount == 0) {
-        continue;
-      }
-
       const baseBranchNode = this.getBaseBranch(uri.fsPath);
       if (folderVulnCount == 0) {
         this.addBaseBranchNode(baseBranchNode, nodes);