fix: apply changes to custom endpoint [IDE-36] #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog (it's manual). Next release tomorrow is a patch release I think :). |
teodora-sandu
force-pushed
the
fix/IDE-36/apply-changes-to-custom-endpoint
branch
from
2c8910a to
f0fcfc0
Compare
|
Thanks @bastiandoetsch! I've added a |
bastiandoetsch
deleted the
fix/IDE-36/apply-changes-to-custom-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the analytics code where if we change the custom endpoint for analytics we don't refresh it when checking if it's permitted. So if someone were to change the custom endpoint to a FedRAMP one for example, it would still send events even if now analytics are not permitted.
Ticket: https://snyksec.atlassian.net/browse/IDE-36
Checklist