Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only send analytics when connected to an MT US environment [IDE-24] #423

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

chdorner-snyk
Copy link
Contributor

@chdorner-snyk chdorner-snyk commented Jan 5, 2024

Description

Since we are having more geographically distributed environments, we should only send analytics to the MT US environments, excluding FedRAMP.

Checklist

  • Tests added and all succeed (skipped the integration tests, as per Basti's suggestion)
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

@chdorner-snyk chdorner-snyk force-pushed the feat/disable-analytics-for-non-mt-us branch 4 times, most recently from b0f4a16 to 06127ec Compare January 5, 2024 16:35
@chdorner-snyk chdorner-snyk force-pushed the feat/disable-analytics-for-non-mt-us branch from 06127ec to e15f1e6 Compare January 10, 2024 10:15
@chdorner-snyk chdorner-snyk marked this pull request as ready for review January 10, 2024 10:17
@chdorner-snyk chdorner-snyk requested a review from a team as a code owner January 10, 2024 10:17
Copy link
Contributor

@cat2608 cat2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!! 💯 🔝
Thank you!

@chdorner-snyk chdorner-snyk merged commit 8c2811b into main Jan 10, 2024
6 checks passed
@chdorner-snyk chdorner-snyk deleted the feat/disable-analytics-for-non-mt-us branch January 10, 2024 13:07
@chdorner-snyk chdorner-snyk changed the title feat: only send analytics when connected to an MT US environment feat: only send analytics when connected to an MT US environment [IDE-24] Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants