Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/show-most-severe-code-action #402

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

bastiandoetsch
Copy link
Contributor

Description

Provide most severe command action

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner November 27, 2023 14:45
j-luong
j-luong previously approved these changes Nov 29, 2023
@j-luong j-luong self-requested a review November 29, 2023 10:08
@j-luong j-luong dismissed their stale review November 29, 2023 10:09

re-checking

Copy link
Contributor

@j-luong j-luong Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: would this file be better in a helpers/ || utils/ dir instead of the providers/ dir?

@j-luong j-luong merged commit 44c0e41 into feat/HEAD-78_oss_via_ls Nov 29, 2023
6 checks passed
@j-luong j-luong deleted the fix/show-most-severe-code-action branch November 29, 2023 14:23
j-luong added a commit that referenced this pull request Nov 29, 2023
* chore: read OSS settings for LS initialisation options
* feat: Language Server based OSS tree view (#386)
* feat: add new OSS (LS) panel in Snyk UI
* feat: configure new views and activation events for LS OSS treeview
* feat: Derive Vulnerability Count from LS results [HEAD-942] (#388)
* feat: enable LS based Vulnerability Count Service
* chore: remove dependency to old OSSService
* chore: cleanup redundant files [HEAD-1020] (#390)
* fix: show most severe vulnerability action is displayed (#402)

---------

Signed-off-by: Bastian Doetsch <[email protected]>
Co-authored-by: Peter Schäfer <[email protected]>
Co-authored-by: Bastian Doetsch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants