fix: oss with multi-module projects #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bastian Doetsch <[email protected]>
Avishagp
approved these changes
Nov 27, 2023
bastiandoetsch
deleted the
fix/HEAD-1066_fix-navigation-in-multi-module-projects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TL;DR: This fixes the display and navigation in the custom UI for Snyk Open Source in multi-module repositories.
Previously, the folder path was assumed to be the parent directory of the package manager manifest file. This is incorrect for multi-module projects, where the opened folder is much higher in the file tree. This PR fixes this, by taking the folder path not from the issue, but from the actual folder configuration.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!