-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: vulnerability count message [HEAD-1024] #391
Merged
j-luong
merged 16 commits into
feat/HEAD-78_oss_via_ls
from
fix/HEAD-1024_vulnerabilityCountMessage
Nov 17, 2023
Merged
fix: vulnerability count message [HEAD-1024] #391
j-luong
merged 16 commits into
feat/HEAD-78_oss_via_ls
from
fix/HEAD-1024_vulnerabilityCountMessage
Nov 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-luong
changed the title
Fix/head 1024 vulnerability count message
fix: vulnerability count message [HEAD-1024]
Nov 13, 2023
j-luong
force-pushed
the
fix/HEAD-1024_vulnerabilityCountMessage
branch
from
November 13, 2023 12:04
4c8d831
to
65f0088
Compare
src/snyk/snykOss/services/vulnerabilityCount/ossVulnerabilityCountService.ts
Show resolved
Hide resolved
src/snyk/snykOss/services/vulnerabilityCount/ossVulnerabilityCountService.ts
Outdated
Show resolved
Hide resolved
src/test/unit/snykOss/providers/vulnerabilityCountProvider.test.ts
Outdated
Show resolved
Hide resolved
bastiandoetsch
approved these changes
Nov 15, 2023
j-luong
added a commit
that referenced
this pull request
Nov 23, 2023
j-luong
added a commit
that referenced
this pull request
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR should switch to LS for vuln count and cleanup some redundant code.
Checklist