feat: Use Detail Panel from Language Server #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bastian Doetsch <[email protected]>
…les CodeActions now
|
Looks very nice. Seeing still differences: |
|
Side by side screeenshots: |
|
I'm aware that the fixes probably are on the LS side - where should we collect discrepancies? |
yes we found in bug in the LS implementation that handles the discrepancies in the details path |
|
let's look at the discrepancies together, from the screenshots, I'm not completely sure what is meant. |
j-luong
approved these changes
Nov 10, 2023
PeterSchafer
deleted the
feat/HEAD-78_HEAD-149_oss_via_ls_detail_panel
branch
j-luong
added a commit
that referenced
this pull request
Nov 23, 2023
* docs: update instructions for contribution to include `npm run build` Signed-off-by: Bastian Doetsch <[email protected]> * chore: use ls based oss service in cmdcontroller * chore: move convertion of Issue to OssVulnerability * chore: adapt test * chore: delete vulnerabilityCountCodeActionProviderLS class as LS handles CodeActions now * chore: delete vulnerabilityCountHoverProvider class as LS handles hovers now * chore: clean up codeaction/hovers where they are not needed anymore * fix: linting * check license data if undefined * chore: display received details html * chore: initial version taking html from ls * chore: inject learn icon * chore: inject nonce and cspsource * fix: linter --------- Signed-off-by: Bastian Doetsch <[email protected]> Co-authored-by: Bastian Doetsch <[email protected]> Co-authored-by: Jason Luong <[email protected]>
j-luong
added a commit
that referenced
this pull request
Nov 23, 2023
* docs: update instructions for contribution to include `npm run build` Signed-off-by: Bastian Doetsch <[email protected]> * chore: use ls based oss service in cmdcontroller * chore: move convertion of Issue to OssVulnerability * chore: adapt test * chore: delete vulnerabilityCountCodeActionProviderLS class as LS handles CodeActions now * chore: delete vulnerabilityCountHoverProvider class as LS handles hovers now * chore: clean up codeaction/hovers where they are not needed anymore * fix: linting * check license data if undefined * chore: display received details html * chore: initial version taking html from ls * chore: inject learn icon * chore: inject nonce and cspsource * fix: linter --------- Signed-off-by: Bastian Doetsch <[email protected]> Co-authored-by: Bastian Doetsch <[email protected]> Co-authored-by: Jason Luong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Language Server sends an HTML Detail panel, which can be shown directly instead of constructing it in the IDE itself.
Checklist
Screenshots / GIFs