Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update code settings only after login #381

Merged
merged 2 commits into from
Oct 17, 2023
Merged

fix: update code settings only after login #381

merged 2 commits into from
Oct 17, 2023

Conversation

bastiandoetsch
Copy link
Contributor

@bastiandoetsch bastiandoetsch commented Oct 17, 2023 •
edited
Loading

Description

Calling updateCodeSettings() doesn't make sense before authentication.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner October 17, 2023 16:19
@bastiandoetsch bastiandoetsch enabled auto-merge (squash) October 17, 2023 16:26
@bastiandoetsch bastiandoetsch merged commit 185b605 into main Oct 17, 2023
3 checks passed
@bastiandoetsch bastiandoetsch deleted the feat/HEAD-779_small-ux-improvements branch October 17, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-luong j-luong j-luong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastiandoetsch @j-luong