Skip to content

Commit

Permalink
fix: make sure old fix panels are closed on startup
Browse files Browse the repository at this point in the history
  • Loading branch information
MichaelAquilina committed Apr 11, 2024
1 parent 77497e3 commit 5efd95c
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions src/snyk/snykCode/views/webviewPanelSerializer.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import * as vscode from 'vscode';
import { WebviewProvider } from '../../../snyk/common/views/webviewProvider';

export class WebviewPanelSerializer<_ extends WebviewProvider<State>, State>

Check failure on line 4 in src/snyk/snykCode/views/webviewPanelSerializer.ts

View workflow job for this annotation

GitHub Actions / Build and Test (ubuntu-latest)

Replace `⏎··implements·vscode.WebviewPanelSerializer⏎` with `·implements·vscode.WebviewPanelSerializer·`
implements vscode.WebviewPanelSerializer
{
constructor() {}

Check failure on line 7 in src/snyk/snykCode/views/webviewPanelSerializer.ts

View workflow job for this annotation

GitHub Actions / Build and Test (ubuntu-latest)

Useless constructor

Check failure on line 7 in src/snyk/snykCode/views/webviewPanelSerializer.ts

View workflow job for this annotation

GitHub Actions / Build and Test (ubuntu-latest)

Unexpected empty constructor
async deserializeWebviewPanel(webviewPanel: vscode.WebviewPanel): Promise<void> {

Check failure on line 8 in src/snyk/snykCode/views/webviewPanelSerializer.ts

View workflow job for this annotation

GitHub Actions / Build and Test (ubuntu-latest)

Async method 'deserializeWebviewPanel' has no 'await' expression
// we want to make sure the panel is closed on startup

Check failure on line 9 in src/snyk/snykCode/views/webviewPanelSerializer.ts

View workflow job for this annotation

GitHub Actions / Build and Test (ubuntu-latest)

Delete `··`
webviewPanel.dispose();

Check failure on line 10 in src/snyk/snykCode/views/webviewPanelSerializer.ts

View workflow job for this annotation

GitHub Actions / Build and Test (ubuntu-latest)

Delete `··`
}
}

0 comments on commit 5efd95c

Please sign in to comment.