Skip to content

Commit

Permalink
fix: colours for consistent ignores styling [IDE-386] (#476)
Browse files Browse the repository at this point in the history
* fix: colours for consistent ignores styling

* fix: font family and size for code

* chor: add TODO for removing the ignore styling
  • Loading branch information
teodora-sandu authored Jun 25, 2024
1 parent 86ba9cf commit 1de87bb
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## [2.12.3]
- Fix a bug in AI Applyfix on Windows.
- Changes some of the colours used in the HTML panel so it's consistent with designs.

## [2.12.2]
- Refactors the feature flag logic into its own service.
Expand Down
18 changes: 14 additions & 4 deletions media/views/snykCode/suggestion/suggestionLS.scss
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ body {
text-transform: capitalize;
}

// TODO: remove ignore styling at the end of cycle 5 2025
.ignore-warning {
background: #FFF4ED;
color: #B6540B;
Expand All @@ -35,16 +36,16 @@ body {
}

.tab-item {
color: var(--vscode-foreground);
color: var(--vscode-panelTitle-inactiveForeground);
border-bottom: 1px solid transparent;
}

.tab-item-icon path {
fill: var(--tab-item-github-icon-color);
fill: var(--vscode-foreground);
}


.tab-item.is-selected {
color: var(--vscode-foreground);
border-bottom: 3px solid var(--vscode-focusBorder);
}

Expand All @@ -65,6 +66,10 @@ body {
padding-bottom: 0px;
}

.data-flow-text {
font-family: "Courier New", Courier, monospace;
}

.ignore-details-tab,
.fix-analysis-tab,
.vuln-overview-tab {
Expand All @@ -77,10 +82,14 @@ body {
}

.example-line-number,
.example-line>code {
.example-line > code {
color: var(--vscode-editor-foreground);
}

.example-line > code {
font-family: "Courier New", Courier, monospace;
}

.example-line.added {
background-color: rgb(204, 255, 216);
}
Expand Down Expand Up @@ -124,6 +133,7 @@ body {
background-color: var(--vscode-editor-background);
background-image: linear-gradient(45deg, rgba(255, 255, 255, 0.075), rgba(255, 255, 255, 0.075));
box-shadow: 0 -1px 3px rgba(0, 0, 0, .05);
border-top: 1px solid var(--vscode-input-border);
}

.ignore-button.secondary {
Expand Down

0 comments on commit 1de87bb

Please sign in to comment.