fix: scan done status (#271)

* fix: scan done status * fix: test should expect Success instead of Succeeded * chore: update changelog --------- Co-authored-by: Abdelrahman Shawki Hassan <[email protected]>
snyk · Jun 7, 2024 · 0bc9a7a · 0bc9a7a
1 parent fd86f66
commit 0bc9a7a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Snyk Security Changelog
 
+## [1.1.57]
+
+### Fixed
+- Change analytics scan status from "Succeeded" to "Success".
+
 ## [1.1.56]
 
 ### Fixed

diff --git a/Snyk.VisualStudio.Extension.Shared/analytics/ScanDoneEvent.cs b/Snyk.VisualStudio.Extension.Shared/analytics/ScanDoneEvent.cs
@@ -75,7 +75,7 @@ string GetArch()
 
         public string EventType => "Scan done";
 
-        public string Status => "Succeeded";
+        public string Status => "Success";
 
         public string ScanType { get; set; }
 
@@ -103,4 +103,4 @@ public class ScanDoneEvent
     {
         public Data Data { get; set; }
     }
-}
+}
diff --git a/Snyk.VisualStudio.Extension.Tests/analytics/SnykIDEAnalyticsServiceTest.cs b/Snyk.VisualStudio.Extension.Tests/analytics/SnykIDEAnalyticsServiceTest.cs
@@ -55,7 +55,7 @@ public void SnykIdeAnalyticsServiceTest_shouldCreateTheCorrectPayloadString()
             Assert.Contains("\"integration_environment\":\"integrationEnvironment\"", payload);
             Assert.Contains("\"integration_environment_version\":\"1.0.0\"", payload);
             Assert.Contains("\"event_type\":\"Scan done\"", payload);
-            Assert.Contains("\"status\":\"Succeeded\"", payload);
+            Assert.Contains("\"status\":\"Success\"", payload);
             Assert.Contains("\"scan_type\":\"product\"", payload);
             Assert.Contains("\"unique_issue_count\":{\"critical\":1,\"high\":2,\"medium\":3,\"low\":4}", payload);
             Assert.Contains("\"duration_ms\":\"100\"", payload);