Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/os management: OSS Docs #21

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

dani-kline
Copy link

Updated the License and CODEOWNERS files to standardize them with the other projects within the Customer Success Engineering team's ownership

Removed asterisk in line 2, col 1
Revised so the license populates for the repo in the Github UI
Copy link
Contributor

@kevin-s31 kevin-s31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be snyk-tech-services but * @snyk-labs/cs-engineers

@kevin-s31
Copy link
Contributor

Also i think the contributor-agreement might be better formatted like this one?

https://github.com/snyk-labs/snyk-user-sync-tool/blob/develop/Contributor-Agreement.md

Corrected an error
@dani-kline
Copy link
Author

dani-kline commented Sep 2, 2022

@kevin-s31

It shouldn't be snyk-tech-services but * @snyk-labs/cs-engineers

Thank you for the catch! I somehow missed that and had also confused myself re: the asterisk.

Also i think the contributor-agreement might be better formatted like this one?

https://github.com/snyk-labs/snyk-user-sync-tool/blob/develop/Contributor-Agreement.md

Noted--Would this be a template or would I need to edit depending on the project?

@dani-kline
Copy link
Author

I've now updated Contributor-Agreement.md 👍

@huytquach-snyk
Copy link

Looks like there is a contributing.md in the .github folder - can you remove it from that folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants