Fix crash on iOS on React Native new architecture (close #212)

PR #213
snowplow · Oct 30, 2024 · f2b7cff · f2b7cff
1 parent 11a6ed9
commit f2b7cff
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 9 deletions.
diff --git a/.github/workflows/e2e-android.yml b/.github/workflows/e2e-android.yml
@@ -111,7 +111,7 @@ jobs:
 
       - name: Upload events artifact if Detox-Jest failed
         if: ${{ failure() && steps.dj.outcome == 'failure' && steps.eventlog.outcome == 'success' }}
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: android-events-artifact
           path: android-events-micro.json

diff --git a/.github/workflows/e2e-ios.yml b/.github/workflows/e2e-ios.yml
@@ -89,7 +89,7 @@ jobs:
 
       - name: Upload events artifact if Detox-Jest failed
         if: ${{ failure() && steps.dj.outcome == 'failure' && steps.eventlog.outcome == 'success' }}
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: ios-events-artifact
           path: ios-events-micro.json
diff --git a/example/ios/Podfile.lock b/example/ios/Podfile.lock
@@ -668,9 +668,9 @@ EXTERNAL SOURCES:
     :path: "../node_modules/react-native/ReactCommon/yoga"
 
 SPEC CHECKSUMS:
-  boost: 57d2868c099736d80fcd648bf211b4431e51a558
+  boost: 7dcd2de282d72e344012f7d6564d024930a6a440
   CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99
-  DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54
+  DoubleConversion: f16ae600a246532c4020132d54af21d0ddb2a385
   FBLazyVector: 25cbffbaec517695d376ab4bc428948cd0f08088
   FBReactNativeSpec: e03b22fbf7017a6f76641ea4472e73c915dcdda7
   Flipper: 6edb735e6c3e332975d1b17956bcc584eccf5818
@@ -682,7 +682,7 @@ SPEC CHECKSUMS:
   Flipper-PeerTalk: 116d8f857dc6ef55c7a5a75ea3ceaafe878aadc9
   FlipperKit: 2efad7007d6745a3f95e4034d547be637f89d3f6
   fmt: ff9d55029c625d3757ed641535fd4a75fedc7ce9
-  glog: 04b94705f318337d7ead9e6d17c019bd9b1f6b1b
+  glog: 08b301085f15bcbb6ff8632a8ebaf239aae04e6a
   hermes-engine: 5b340c6a5affbf3aba22185be41563bbb2426654
   libevent: 4049cae6c81cdb3654a443be001fb9bdceff7913
   OpenSSL-Universal: ebc357f1e6bc71fa463ccb2fe676756aff50e88c

diff --git a/ios/ReactNativeTracker.mm b/ios/ReactNativeTracker.mm
@@ -2,10 +2,6 @@
 
 @interface RCT_EXTERN_MODULE(ReactNativeTracker, NSObject)
 
-RCT_EXTERN_METHOD(multiply:(float)a withB:(float)b
-                 withResolver:(RCTPromiseResolveBlock)resolve
-                 withRejecter:(RCTPromiseRejectBlock)reject)
-
 RCT_EXTERN_METHOD(createTracker:
                   (NSDictionary *)argmap
                   resolver:(RCTPromiseResolveBlock)resolve