Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging from main into decoder branch. #2826

Open
wants to merge 14 commits into
base: vbudati/SNOW-1794510-merge-decoder
Choose a base branch
from
Open

Merging from main into decoder branch. #2826

wants to merge 14 commits into from

Conversation

sfc-gh-batur
Copy link

@sfc-gh-batur sfc-gh-batur commented Jan 6, 2025 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

sfc-gh-joshi and others added 14 commits December 19, 2024 20:40
@sfc-gh-joshi
SNOW-1722641: Add support for Series.between (#2775)
be0ae7b 
<!---
Please answer these questions before creating your pull request. Thanks!
--->

1. Which Jira issue is this PR addressing? Make sure that there is an
accompanying issue to your PR.

   <!---
   In this section, please add a Snowflake Jira issue number.

Note that if a corresponding GitHub issue exists, you should still
include
   the Snowflake Jira issue number. For example, for GitHub issue
#1400, you should
   add "SNOW-1335071" here.
    --->

   Fixes SNOW-1722641

2. Fill out the following pre-review checklist:

- [x] I am adding a new automated test(s) to verify correctness of my
new code
- [ ] If this test skips Local Testing mode, I'm requesting review from
@snowflakedb/local-testing
   - [ ] I am adding new logging messages
   - [ ] I am adding a new telemetry message
   - [ ] I am adding new credentials
   - [ ] I am adding a new dependency
- [ ] If this is a new feature/behavior, I'm adding the Local Testing
parity changes.
- [x] I acknowledge that I have ensured my changes to be thread-safe.
Follow the link for more information: [Thread-safe Developer
Guidelines](https://github.com/snowflakedb/snowpark-python/blob/main/CONTRIBUTING.md#thread-safe-development)

3. Please describe how your code solves the related issue.

Implements `Series.between`. The frontend implementation uses [modin's
implementation](https://github.com/modin-project/modin/blob/1c4d173d3b2c44a1c1b5d5516552c7717b26de32/modin/pandas/series.py#L795),
which passes the `modin.pandas.Series` object to the [native pandas
method](https://github.com/pandas-dev/pandas/blob/9fe33bcbca79e098f9ba8ffd9fcf95440b95032b/pandas/core/series.py#L5362-L5380),
which directly uses comparison operators to implement the method.
@sfc-gh-aalam
SNOW-1794369 Catalog API (#2655)
4ae4c4d
@sfc-gh-helmeleegy
SNOW-1866086: Fix test_dt_accessor.py::test_strftime in Windows (#2798)
c388f00 
<!---
Please answer these questions before creating your pull request. Thanks!
--->

1. Which Jira issue is this PR addressing? Make sure that there is an
accompanying issue to your PR.

   <!---
   In this section, please add a Snowflake Jira issue number.

Note that if a corresponding GitHub issue exists, you should still
include
   the Snowflake Jira issue number. For example, for GitHub issue
#1400, you should
   add "SNOW-1335071" here.
    --->

   Fixes SNOW-1866086

2. Fill out the following pre-review checklist:

- [x] I am adding a new automated test(s) to verify correctness of my
new code
- [ ] If this test skips Local Testing mode, I'm requesting review from
@snowflakedb/local-testing
   - [ ] I am adding new logging messages
   - [ ] I am adding a new telemetry message
   - [ ] I am adding new credentials
   - [ ] I am adding a new dependency
- [ ] If this is a new feature/behavior, I'm adding the Local Testing
parity changes.
- [ ] I acknowledge that I have ensured my changes to be thread-safe.
Follow the link for more information: [Thread-safe Developer
Guidelines](https://github.com/snowflakedb/snowpark-python/blob/main/CONTRIBUTING.md#thread-safe-development)

3. Please describe how your code solves the related issue.

   Fix test_dt_accessor.py::test_strftime in Windows.
@sfc-gh-vbudati
SNOW-1866100 Update DataFrame.unpivot AST encoding to include `includ…
80ef534 
…e_nulls` (#2800)

1. Which Jira issue is this PR addressing? Make sure that there is an
accompanying issue to your PR.

   Fixes SNOW-1866100

2. Fill out the following pre-review checklist:

- [ ] I am adding a new automated test(s) to verify correctness of my
new code
- [ ] If this test skips Local Testing mode, I'm requesting review from
@snowflakedb/local-testing
   - [ ] I am adding new logging messages
   - [ ] I am adding a new telemetry message
   - [ ] I am adding new credentials
   - [ ] I am adding a new dependency
- [ ] If this is a new feature/behavior, I'm adding the Local Testing
parity changes.
- [x] I acknowledge that I have ensured my changes to be thread-safe.
Follow the link for more information: [Thread-safe Developer
Guidelines](https://github.com/snowflakedb/snowpark-python/blob/main/CONTRIBUTING.md#thread-safe-development)

3. Please describe how your code solves the related issue.
Update DataFrame.unpivot AST encoding to include `include_nulls`
@sfc-gh-helmeleegy
SNOW-1865997: Use docstrings folder for DatetimeIndex methods and pro…
20cfeed 
…perties (#2795)

<!---
Please answer these questions before creating your pull request. Thanks!
--->

1. Which Jira issue is this PR addressing? Make sure that there is an
accompanying issue to your PR.

   <!---
   In this section, please add a Snowflake Jira issue number.

Note that if a corresponding GitHub issue exists, you should still
include
   the Snowflake Jira issue number. For example, for GitHub issue
#1400, you should
   add "SNOW-1335071" here.
    --->

   Fixes SNOW-1865997

2. Fill out the following pre-review checklist:

- [ ] I am adding a new automated test(s) to verify correctness of my
new code
- [ ] If this test skips Local Testing mode, I'm requesting review from
@snowflakedb/local-testing
   - [ ] I am adding new logging messages
   - [ ] I am adding a new telemetry message
   - [ ] I am adding new credentials
   - [ ] I am adding a new dependency
- [ ] If this is a new feature/behavior, I'm adding the Local Testing
parity changes.
- [ ] I acknowledge that I have ensured my changes to be thread-safe.
Follow the link for more information: [Thread-safe Developer
Guidelines](https://github.com/snowflakedb/snowpark-python/blob/main/CONTRIBUTING.md#thread-safe-development)

3. Please describe how your code solves the related issue.

Use docstrings folder for DatetimeIndex methods and properties.
Docstrings for TimedeltaIndex will be treated similarly in a follow-up
PR
@sfc-gh-mvashishtha @sfc-gh-helmeleegy
SNOW-1805851: Add scikit-learn interoperability tests. (#2796)
637905b 
- Move the existing scikit-learn interoperability test into the
`interoperability` test folder.
- Refactor the test file so that it groups test cases into scikit-learn
method categories, like classification and regression.
- Add test cases so we have one test case for each category.
- Remove the scikit-learn version pin for the modin dev environment.
Once we implemented the interchange protocol, we no longer needed that
pin.
- Document the support for the methods that we've tested.
- Reorganize the interoperability documentation page so that it follows
the rst guidelines for sections and subsections.

Signed-off-by: sfc-gh-mvashishtha <[email protected]>
Co-authored-by: Hazem Elmeleegy <[email protected]>
@sfc-gh-jrose
SNOW-1865595: Add currently supported structured type functions (#2790)
69c41a2
@sfc-gh-aalam
SNOW-981562: Expose is_temp_table_for_cleanup to Session.table (#2784)
ba31301
@sfc-gh-aalam
SNOW-1869362: Plan plotter improvements (#2813)
e75b506
@sfc-gh-aalam
SNOW-1869388 add memoization to to_selectable (#2815)
10c612e
@sfc-gh-aalam
SNOW-1865904 fix query gen when nested cte node is partitioned (#2816)
a79fe9f
@sfc-gh-jrose
SNOW-1829870: Allow structured types to be enabled by default (#2727)
888cec5
@sfc-gh-jrose
SNOW-1853347: Add mechanism to allow changing type strs when printing…
2247ae5 
… schema (#2819)
@sfc-gh-batur
Merge branch 'main' into vbudati/SNOW-1794510-merge-decoder
b0d1659
@sfc-gh-batur sfc-gh-batur self-assigned this Jan 6, 2025
@sfc-gh-batur sfc-gh-batur requested review from a team as code owners January 6, 2025 21:34
@sfc-gh-batur sfc-gh-batur requested review from sfc-gh-rdurrani, sfc-gh-aling, sfc-gh-aalam and sfc-gh-jrose and removed request for a team January 6, 2025 21:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025

Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-vbudati sfc-gh-vbudati Awaiting requested review from sfc-gh-vbudati

Assignees

@sfc-gh-batur sfc-gh-batur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sfc-gh-batur @sfc-gh-joshi @sfc-gh-aalam @sfc-gh-helmeleegy @sfc-gh-vbudati @sfc-gh-mvashishtha @sfc-gh-jrose