Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1805851: Add scikit-learn interoperability tests. #2796

Merged
merged 5 commits into from
Dec 20, 2024
Merged

SNOW-1805851: Add scikit-learn interoperability tests. #2796

merged 5 commits into from
Dec 20, 2024

Conversation

sfc-gh-mvashishtha
Copy link
Contributor

@sfc-gh-mvashishtha sfc-gh-mvashishtha commented Dec 19, 2024 •
edited
Loading

  • Move the existing scikit-learn interoperability test into the interoperability test folder.
  • Refactor the test file so that it groups test cases into scikit-learn method categories, like classification and regression.
  • Add test cases so we have one test case for each category.
  • Remove the scikit-learn version pin for the modin dev environment. Once we implemented the interchange protocol, we no longer needed that pin.
  • Document the support for the methods that we've tested.
  • Reorganize the interoperability documentation page so that it follows the rst guidelines for sections and subsections.

@sfc-gh-mvashishtha sfc-gh-mvashishtha marked this pull request as ready for review December 19, 2024 23:43
@sfc-gh-mvashishtha sfc-gh-mvashishtha requested review from a team as code owners December 19, 2024 23:43
sfc-gh-jrose
sfc-gh-jrose approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-jrose sfc-gh-jrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes look real clean 🎉

sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks! Just left a few nits.

sfc-gh-lmukhopadhyay
sfc-gh-lmukhopadhyay reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great! Just left a couple of comments

setup.py Outdated Show resolved Hide resolved
tests/integ/modin/interoperability/scikit-learn/test_scikit_learn.py Show resolved Hide resolved
@sfc-gh-mvashishtha sfc-gh-mvashishtha enabled auto-merge (squash) December 20, 2024 20:07
@sfc-gh-mvashishtha sfc-gh-mvashishtha merged commit 637905b into main Dec 20, 2024
42 checks passed
@sfc-gh-mvashishtha sfc-gh-mvashishtha deleted the mvashishtha/SNOW-1805851/add-scikit-learn-interoperability-suite-and-documentation branch December 20, 2024 20:49
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay sfc-gh-lmukhopadhyay approved these changes

@sfc-gh-joshi sfc-gh-joshi Awaiting requested review from sfc-gh-joshi sfc-gh-joshi is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-jdu sfc-gh-jdu Awaiting requested review from sfc-gh-jdu sfc-gh-jdu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-nkumar sfc-gh-nkumar Awaiting requested review from sfc-gh-nkumar

Assignees
No one assigned
Labels
snowpark-pandas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-mvashishtha @sfc-gh-lmukhopadhyay @sfc-gh-helmeleegy @sfc-gh-jrose