Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1660947 Improved warning messages for operations lead to materia… #2352

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

sfc-gh-azhan
Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan commented Sep 24, 2024

…lization with inadvertent slowness.

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1660947

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

SNOW-1660947 Improved warning messages for operations lead to materialization with inadvertent slowness. This PR should cover all materialization cases missing warning today.

@sfc-gh-azhan sfc-gh-azhan added the NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs label Sep 24, 2024
@sfc-gh-azhan sfc-gh-azhan force-pushed the azhan-warn-1660947 branch 2 times, most recently from 8d2ec6f to 419ece9 Compare September 24, 2024 23:39
@sfc-gh-azhan sfc-gh-azhan marked this pull request as ready for review September 24, 2024 23:41
@sfc-gh-azhan sfc-gh-azhan requested a review from a team as a code owner September 24, 2024 23:41
Copy link
Contributor

@sfc-gh-vbudati sfc-gh-vbudati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andong!

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Varnika Budati <[email protected]>
Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-azhan sfc-gh-azhan merged commit 6787f2b into main Sep 25, 2024
37 checks passed
@sfc-gh-azhan sfc-gh-azhan deleted the azhan-warn-1660947 branch September 25, 2024 20:53
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants