Skip to content

Commit

Permalink
Respond to comments.
Browse files Browse the repository at this point in the history
Signed-off-by: sfc-gh-mvashishtha <[email protected]>
  • Loading branch information
sfc-gh-mvashishtha committed Dec 20, 2024
1 parent 605bd76 commit 9d2da06
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ def run(self):
*DEVELOPMENT_REQUIREMENTS,
"scipy", # Snowpark pandas 3rd party library testing
"statsmodels", # Snowpark pandas 3rd party library testing
"scikit-learn",
"scikit-learn", # Snowpark pandas 3rd party library testing
# plotly version restricted due to foreseen change in query counts in version 6.0.0+
"plotly<6.0.0", # Snowpark pandas 3rd party library testing
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,10 @@
data)
3) Write a test case checking that replacing the pandas input with Snowpark
pandas produces results of the same type and, in the case of array-like
outputs, of the same dimensions.
outputs, of the same dimensions. `assert_numpy_results_valid` can validate
numpy results. Avoid checking that the values in the result are the same
values we would get if we use pandas, because many scikit-learn methods
are non-deterministic.
4) Wrap the test with an empty sql_count_checker() decorator to see how many
queries and joins it requires. If it it requires a very large number of
queries, see if you can simplify the test case so that it causes fewer
Expand Down

0 comments on commit 9d2da06

Please sign in to comment.