feat: add members space page #971
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feat-960-add-members-space-page
bonustrack
reviewed
Nov 7, 2024
Co-authored-by: Less <[email protected]>
|
@Sekhmet can you review this PR? |
Sekhmet
reviewed
Nov 27, 2024
Comment on lines
+72
to
+80
| const canSeeMembers = computed(() => { | ||
| const data = space.value?.additionalRawData; | ||
|
|
||
| return ( | ||
| controller.value || | ||
| (data?.admins?.length ?? 0) > 0 || | ||
| (data?.moderators?.length ?? 0) > 0 || | ||
| (data?.members?.length ?? 0) > 0 | ||
| ); |
There was a problem hiding this comment.
This makes this section visible on Snapshot onchain spaces, original issue includes this:
The page should only appear if there are members set on the space (only appear on Snapshot spaces and not SX).
Might be confusing though (Snapshot spaces = Snapshot offchain spaces, SX = Snapshot onchain spaces).
|
|
||
| const network = getNetwork(networkId.value); | ||
| const controller = await network.helpers.getSpaceController(space.value); | ||
| return await network.helpers.getSpaceController(space.value); |
There was a problem hiding this comment.
Suggested change
| return await network.helpers.getSpaceController(space.value); | |
| return network.helpers.getSpaceController(space.value); |
await there does nothing.
| const isController = computed(() => { | ||
| const { account } = web3.value; | ||
|
|
||
| return compareAddresses(controller.value ?? '', account); |
There was a problem hiding this comment.
nit. I'd just check if it's undefined as separate case to avoid calling compareAddresses with fallback value.
| @@ -360,3 +360,18 @@ export const STRATEGY_QUERY = gql` | |||
| } | |||
| ${STRATEGY_FRAGMENT} | |||
| `; | |||
|
|
|||
| export const STATEMENTS_AND_USERS_QUERY = gql` | |||
| query ($where: StatementsWhere, $userIds: [String!]) { | |||
There was a problem hiding this comment.
Suggested change
| query ($where: StatementsWhere, $userIds: [String!]) { | |
| query ($statementsWhere: StatementsWhere, $userIds: [String!]) { |
This way it's clearer when we execute query as to what where refers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new space page and item in the space menu called "Members".
Closes: #960
How to test
Membersnavigation item is visibleMembers