Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: offchain pending proposal voting power should not use latest block #941

Open
wants to merge 2 commits into
base: refactor-vote-vp-composable
Choose a base branch
from
Open

fix: offchain pending proposal voting power should not use latest block #941

wants to merge 2 commits into from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Oct 24, 2024 •
edited
Loading

Summary

Closes: #940
Depends on #938

This PR fix the voting power for offchain pending proposal, which were based on latest block, instead of the proposal own snapshot

How to test

  1. Open the network in the dev console
  2. Go to an offchain pending proposal
  3. Inspect the payload for https://score.snapshot.org/
  4. It should use a number as snapshot, instead of latest

@wa0x6e wa0x6e changed the title Fix-wrong-offchain-pending-vp fix: offchain pending proposal voting power should not use latest block Oct 24, 2024
@wa0x6e wa0x6e marked this pull request as ready for review October 24, 2024 20:29
@ChaituVR
Copy link
Member

description says it depends on #938

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Nov 22, 2024

description says it depends on #938

Correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @ChaituVR