Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: load statement in delegation dashboard #4892

Merged
merged 4 commits into from
Sep 29, 2024
Merged

feat: load statement in delegation dashboard #4892

merged 4 commits into from
Sep 29, 2024

Conversation

wa0x6e
Copy link
Collaborator

@wa0x6e wa0x6e commented Sep 29, 2024 •
edited
Loading

Summary

This PR loads and shows the statement for each delegation card, in the delegation dashboard.
Also proceeded to some little refactoring to truncate username when needed

How to test

  1. Go to http://localhost:8080/#/test.wa0x6e.eth/delegates
  2. Each delegation card now shows the statement, the username when available instead of just the address

@wa0x6e wa0x6e marked this pull request as ready for review September 29, 2024 20:05
bonustrack
bonustrack approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@wa0x6e wa0x6e merged commit db8b63a into master Sep 29, 2024
5 checks passed
@wa0x6e wa0x6e deleted the load-statement-in-delegation-dashboard branch September 29, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack approved these changes

@ChaituVR ChaituVR Awaiting requested review from ChaituVR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @bonustrack