Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: numWinners should be string instead of number #4805

Merged
merged 1 commit into from
Jul 4, 2024
Merged

fix: numWinners should be string instead of number #4805

merged 1 commit into from
Jul 4, 2024

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Jul 3, 2024 •
edited
Loading

Fix from #4804

  • numWinners should be a string instead of a number

How to test:

  • Create a boost with lottery type
  • In the pinned file, "numWinners" should be a string

bonustrack
bonustrack reviewed Jul 3, 2024
View reviewed changes
Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is that

@ChaituVR
Copy link
Member Author

ChaituVR commented Jul 3, 2024

It was like this before, All numbers are string in pinned file , for example https://bafybeic6rdzoszofbxm53uws5hc6wnhj7xuazmuxu7mo6iytekh27dh6e4.ipfs.4everland.io/
but was changed to Number() by me in #4804

@ChaituVR ChaituVR requested a review from wa0x6e July 3, 2024 13:39
wa0x6e
wa0x6e approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@ChaituVR ChaituVR merged commit c820500 into master Jul 4, 2024
5 checks passed
@ChaituVR ChaituVR deleted the fix-num-winners-string branch July 4, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack bonustrack left review comments

@wa0x6e wa0x6e wa0x6e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChaituVR @wa0x6e @bonustrack