Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use domain field instead of one in JSON #944

Merged
merged 3 commits into from
Oct 10, 2024
Merged

fix: Use domain field instead of one in JSON #944

merged 3 commits into from
Oct 10, 2024

Conversation

ChaituVR
Copy link
Member

Related to https://github.com/snapshot-labs/workflow/issues/241

Summery

  • Use domain field instead of domain in settings JSON

How to test:

  • Change domain field and settings.domain
  • Hub queries should return domain field instead of domain in JSON

@ChaituVR ChaituVR requested a review from wa0x6e October 10, 2024 07:50
wa0x6e
wa0x6e approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@wa0x6e wa0x6e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@ChaituVR ChaituVR merged commit e046e4e into master Oct 10, 2024
2 checks passed
@ChaituVR ChaituVR deleted the fix-use-domain-field branch October 10, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wa0x6e wa0x6e wa0x6e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @wa0x6e