Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get skins data from DB directly #716

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: get skins data from DB directly #716

wants to merge 2 commits into from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Oct 18, 2023

🧿 Current issues / What's wrong ?

The skin query on the hub is using data from space's cache.
This create refresh lag, and dependency on the space cache object.

💊 Fixes / Solution

Use a SQL query to get skins data from the database

🚧 Changes

  • Get skins data from the database

🛠️ Tests

  • Query some skin data from graphql => it should return same results as before

@wa0x6e wa0x6e requested a review from ChaituVR October 18, 2023 06:39
@wa0x6e wa0x6e added this to the Remove space cache milestone Oct 19, 2023
@wa0x6e
Copy link
Contributor Author

wa0x6e commented Nov 6, 2023

Query is taking between 300 and 350ms to execute on main net database.

This is reasonable, considering a simple SELECT id FROM spaces WHERE id = ? is taking between 250 and 300ms.

@wa0x6e wa0x6e added the enhancement New feature or request label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR Awaiting requested review from ChaituVR

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Remove space cache
Development

Successfully merging this pull request may close these issues.
1 participant
@wa0x6e