Don't flag the wheel as a "manylinux" wheel #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manylinux is a pep8 policy that assert that the wheels are usable on a variety of Linux machines that satisfy standard requirements. In order for a wheel to be manylinux compatible, it must respect some requirements as well. They are described in https://www.python.org/dev/peps/pep-0513/#the-manylinux1-policy The current snap wheels do not satisfy these requirements (see snap-stanford#122), and therefore cannot be flagged as Manylinux compatible. In the wait of a solution that patches the wheel, this PR removes the incorrect flagging.
|
This issue will be fixed in the upcoming update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manylinux is a pep8 policy that assert that the wheels are usable on a
variety of Linux machines that satisfy standard requirements.
In order for a wheel to be manylinux compatible, it must respect some
requirements as well. They are described in
https://www.python.org/dev/peps/pep-0513/#the-manylinux1-policy
The current snap wheels do not satisfy these requirements (see #122), and
therefore cannot be flagged as Manylinux compatible.
In the wait of a solution that patches the wheel, this PR removes the incorrect flagging.