Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wheels manylinux compliant #122

Open
wizmer opened this issue Jun 9, 2020 · 0 comments
Open

Make wheels manylinux compliant #122

wizmer opened this issue Jun 9, 2020 · 0 comments

Comments

@wizmer
Copy link
Contributor

wizmer commented Jun 9, 2020

Hi,

It seems the linux wheels are not manylinux compliant.
I just had a problem similar to snap-stanford/snap#189 and it is caused by the wheels being built with a too recent version of GLIBC.
The manylinux policy https://www.python.org/dev/peps/pep-0513/#id40 requires that the wheel should be built with GLIBC <= 2.5 while here 2.27 was used.

I could try to fix this using https://github.com/matthew-brett/multibuild/ but I would like to be sure that the proposition would be accepted before starting the work.
For reference, I already have some experience with manylinux (https://github.com/BlueBrain/libsonata-wheels/ and https://github.com/BlueBrain/morphio-wheels/ are managed by myself)

Thanks

wizmer pushed a commit to wizmer/snap-python that referenced this issue Jun 11, 2020
Manylinux is a pep8 policy that assert that the wheels are usable on a
variety of Linux machines that satisfy standard requirements.

In order for a wheel to be manylinux compatible, it must respect some
requirements as well. They are described in
https://www.python.org/dev/peps/pep-0513/#the-manylinux1-policy

The current snap wheels do not satisfy these requirements (see snap-stanford#122), and
therefore cannot be flagged as Manylinux compatible.

In the wait of a solution that patches the wheel, this PR removes the incorrect flagging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant