fix: create pool with mgmt batch client #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakevc
pushed a commit
that referenced
this pull request
Jul 20, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.0](v0.1.3...v0.2.0) (2024-07-20) ### Features * keep pool option ([#22](#22)) ([106b48a](106b48a)) ### Bug Fixes * create pool with mgmt batch client ([#10](#10)) ([7bddf40](7bddf40)), closes [#7](#7) * update snakemake-storage-plugin-s3 requirement from 0.2.8 to 0.2.10 ([#17](#17)) ([88625d6](88625d6)) * update to latest snakemake-interface-executor-plugins ([#18](#18)) ([5b145a9](5b145a9)) ### Documentation * update usage ([#23](#23)) ([613ec1a](613ec1a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates batch pool creation to use azure.mgmt.batch.Pool.create instead of azure.batch.Pool.add. This is allows the managed identity and autoscale settings to be configured at pool creation instead of being updated after the fact.
I found that enabling the managed identity after the fact using the azure.batch.Pool API does not work as expected. The pool resource must be created with the managed identity.
fixes #7