Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Expose gene annotation params #16

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

fix: Expose gene annotation params #16

wants to merge 6 commits into from

Conversation

tedil
Copy link
Collaborator

@tedil tedil commented Feb 29, 2024

Expose flavor and branch in the config.yaml. Also update the config schema accordingly (and fix the varlociraptor fdr mode schema entries)

@tedil tedil requested a review from dlaehnemann February 29, 2024 10:44
@tedil tedil changed the title Expose gene annotation params fix: Expose gene annotation params Feb 29, 2024
dlaehnemann
dlaehnemann approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@dlaehnemann dlaehnemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions.

Also, maybe it makes sense to create a big "we update all of the wrappers and conda envs" pull request? Just saw that the ref download wrapper is still at v1...

config/config.yaml Outdated Show resolved Hide resolved
config/config.yaml Show resolved Hide resolved
workflow/schemas/config.schema.yaml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlaehnemann dlaehnemann dlaehnemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tedil @dlaehnemann