Adding ATtiny 4313 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rking) - added comments to most of the functions (still some TODOs) - elaborated a bit on the timing macros, which led to wrong values for F_CPU=8MHz - removed unused functions in uart.c (which were not ported to atmega32) - some beautifying of the code
… are still the same
…fied 8bit and 16bit types, using register variables as a test only
…e now (not globally), receiver blocks aswell (bug), reduced ifdef hell to a more acceptable level, this was triggered by latency problems during debug
… top of features.h
…ment fixed (was copied from ds2423.c)
…it more debugging code, S_OPCODE defined for opcode states, set_reset inlined
…d debug information accordingly, some beautifying and more documentation
…pted for cortex compile and bin-utils
- introduced owtimer_is_set_to_short_timeout() instead of unportable (TCNT < 0xF0) - documentation added in onewire.c - short circuit evaluation turned again (more probable situation evaluated faster) - moved header dependencies, features.h now only holds features ;-) - cpu specific function composition moved to onewire.c (no-one else needs it) - AVR specific optimization (registers) removed (was #if 0 already)
Some minor changes to the Makefile
- minor adaption of T_SAMPLE for 12MHz quartz - ISR macros for T1 added Reported and tested by Robin Gilks <[email protected]>.
Conflicts: Makefile avr_uart.c features.h onewire.c onewire.h
|
Owch. I just noticed your pull request … Do you still use the code? I'm afraid that a lot has changed. However, most of your fixes still make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the ATtiny4313 to the source.
While using the ATtiny4313 I've found T_SAMPLE to be to short to receive any ROM codes. Changing it to 25 resolved this. I'm not sure how this works for other Atmels, so I've changed it using an #ifdef
Furthermore, I've made some changes to the Makefile that I think should improve it. There are however also some small changes there for my programmer you probably don't want. Since I'm new to git I'm not sure how to leave them out of this push/pull.
Best regards,
Marc Dirix