Remove many remaining uses of references #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See smrealms#317. This handles three major remaining usages: * When returning objects or arrays from class methods. Objects should almost always be returned "by value" (since they are handled internally as references by PHP). Arrays should be returned "by value" except, perhaps, if they will be modified. * In foreach loops. The only time a reference is needed here is when you want to loop over an array and modify array elements. * In template includes. We never want to modify variables within templates, so there is no reason to use references here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #317.
This handles three major remaining usages:
When returning objects or arrays from class methods.
Objects should almost always be returned "by value" (since they
are handled internally as references by PHP). Arrays should be
returned "by value" except, perhaps, if they will be modified.
In foreach loops. The only time a reference is needed here is
when you want to loop over an array and modify array elements.
In template includes. We never want to modify variables within
templates, so there is no reason to use references here.