Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to PHPStan 2.0 #1982

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Update to PHPStan 2.0 #1982

merged 1 commit into from
Dec 13, 2024

Conversation

hemberger
Copy link
Member

  • Update rector to 2.0 as well due to its PHPStan dependency.
  • Remove some checkAlwaysTrue* options that are now true by default.
  • Fix errors reported by PHPStan 2.0 (some typos, wrong types, and wide types).

* Update rector to 2.0 as well due to its PHPStan dependency.
* Remove some `checkAlwaysTrue*` options that are now true by default.
* Fix errors reported by PHPStan 2.0 (some typos, wrong types, and
  wide types).
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 31.42%. Comparing base (07bec22) to head (a663b73).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/Default/alliance_pick.inc.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1982      +/-   ##
============================================
- Coverage     31.42%   31.42%   -0.01%     
  Complexity     4203     4203              
============================================
  Files           125      125              
  Lines         12807    12809       +2     
============================================
  Hits           4025     4025              
- Misses         8782     8784       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hemberger hemberger merged commit 1817dd6 into smrealms:main Dec 13, 2024
7 of 8 checks passed
@hemberger hemberger deleted the phpstan-2.0 branch December 13, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant