Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHPUnit deprecations #1981

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Fix PHPUnit deprecations #1981

merged 3 commits into from
Dec 13, 2024

Conversation

hemberger
Copy link
Member

  • Fix deprecations
  • Make deprecations an error in the future
  • Update xml schema to version 11.5

By default, PHPUnit deprecations are hidden. We now make them a visible
error so that they can be fixed in a timely manner.
Run the migration command with PHPUnit 11.5 to update the schema. Only
one non-trivial change was made:

* `includeUncoveredFiles` was removed because true is the default
> Targeting a trait such as Smr\Container\ResettableContainerTrait with #[CoversTrait] is deprecated. The traits used by the class(es) you target with #[CoversClass] will be targeted as well.

Presumably this is the correct thing to do and won't change the coverage
results.
@hemberger hemberger merged commit 07bec22 into smrealms:main Dec 13, 2024
8 checks passed
@hemberger hemberger deleted the phpunit-updates branch December 13, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant