resend_password_processing.php: do not throw on no email #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `email` request field doesn't exist, an error is thrown and it sends a bug report email. Even though the actual page has an HTML5 form property that prevents submitting an empty email, it appears that crawlers are submitting this page without the `email` field. We can prevent this bug report email if we default `email` to an empty string, so that the user gets an error message response. This is not ideal, because it means that if the form breaks (e.g. field is changed without updating the processor), we won't get bug emails, but I think this is necessary to avoid the sheer volume of crawler bug emails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
emailrequest field doesn't exist, an error is thrown and it sends a bug report email. Even though the actual page has an HTML5 form property that prevents submitting an empty email, it appears that crawlers are submitting this page without theemailfield.We can prevent this bug report email if we default
emailto an empty string, so that the user gets an error message response. This is not ideal, because it means that if the form breaks (e.g. field is changed without updating the processor), we won't get bug emails, but I think this is necessary to avoid the sheer volume of crawler bug emails.