Cloak ambush bonus

src/engine/Default/trader_attack_processing.php

@@ -47,7 +47,10 @@
 //decloak all fighters
 foreach ($fightingPlayers as $teamPlayers) {
 	foreach ($teamPlayers as $teamPlayer) {
-		$teamPlayer->getShip()->decloak();
+		if ($teamPlayer->getShip()->isCloaked()) {
+			$teamPlayer->getShip()->setAmbush();
+			$teamPlayer->getShip()->decloak();
+		}
 	}
 }
 

src/lib/Default/AbstractSmrCombatWeapon.php

@@ -64,6 +64,9 @@ protected function doPlayerDamageToForce(array $return, AbstractSmrPlayer $weapo
 
 	protected function doPlayerDamageToPlayer(array $return, AbstractSmrPlayer $weaponPlayer, AbstractSmrPlayer $targetPlayer): array {
 		$return['WeaponDamage'] = $this->getModifiedDamageAgainstPlayer($weaponPlayer, $targetPlayer);
+		if ($weaponPlayer->getShip()->getAmbush()) {
+			$return ['WeaponDamage'] *= 1.1;
+		}
 		$return['ActualDamage'] = $targetPlayer->getShip()->takeDamage($return['WeaponDamage']);
 
 		if ($return['ActualDamage']['KillingShot']) {

src/lib/Default/AbstractSmrShip.php

@@ -34,6 +34,7 @@ class AbstractSmrShip {
 	protected array $hardware = [];
 	protected bool $isCloaked = false;
 	protected array|false $illusionShip = false;
+	protected bool $ambush = false;
 
 	protected bool $hasChangedWeapons = false;
 	protected bool $hasChangedCargo = false;
@@ -367,6 +368,27 @@ public function getIllusionAttack(): int {
 	public function getIllusionDefense(): int {
 		return $this->getIllusionShip()['Defense'];
 	}
+
+	/**
+	 *  returns whether or not an ambush bonus is active
+	 */
+	public function getAmbush() : bool {
+		return $this->ambush;
+	}
+
+	/**
+	 *  sets ambush bonus firing out of cloak
+	 */
+	public function setAmbush() : void {
+		$this->ambush = true;
+	}
+
+	/**
+	 *  clears ambush bonus after shot out of cloak
+	 */
+	public function clearAmbush() : void {
+		$this->ambush = false;
+	}
 
 	public function getPlayer(): AbstractSmrPlayer {
 		return $this->player;
@@ -761,6 +783,7 @@ public function shootPlayers(array $targetPlayers): array {
 			$results['Drones'] = $thisCDs->shootPlayer($thisPlayer, array_rand_value($targetPlayers));
 			$results['TotalDamage'] += $results['Drones']['ActualDamage']['TotalDamage'];
 		}
+		$thisPlayer->getShip()->clearAmbush();
 		$thisPlayer->increaseExperience(IRound($results['TotalDamage'] * self::EXP_PER_DAMAGE_PLAYER));
 		$thisPlayer->increaseHOF($results['TotalDamage'], ['Combat', 'Player', 'Damage Done'], HOF_PUBLIC);
 		$thisPlayer->increaseHOF(1, ['Combat', 'Player', 'Shots'], HOF_PUBLIC);