Skip to content
This repository has been archived by the owner on Aug 24, 2019. It is now read-only.

Timer #24

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Timer #24

merged 1 commit into from
Jan 25, 2018

Conversation

rhy0u
Copy link
Contributor

@rhy0u rhy0u commented Jan 25, 2018

#10 Timer component

@rhy0u rhy0u self-assigned this Jan 25, 2018
@rhy0u rhy0u requested a review from gregberge January 25, 2018 09:32
describe('Timer', () => {
it('should render a timer', () => {
const wrapper = shallow(<Timer countdown={42} />)
console.log(wrapper.debug())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??


const Timer = props => (
<div>
<span>{props.countdown}</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Destructuring

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ajoute aussi des PropTypes

@gregberge
Copy link
Member

Pour rebase tu fais git rebase -i origin/master et après tu peux réorganiser les commits.

@gregberge gregberge merged commit 88cf421 into master Jan 25, 2018
@gregberge gregberge deleted the Timer branch January 25, 2018 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants